Merged
Conversation
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
|
Connected to Huly®: UBERF-13865 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a DSL (Domain Specific Language) for SelectedContext to replace the JSON-based approach for better performance with nested contexts. The DSL provides a more compact representation that reduces payload size significantly.
- Implements a bi-directional DSL parser and serializer for SelectedContext objects
- Updates context parsing to fallback to DSL when JSON parsing fails
- Refactors ProcessAttribute component to use DSL format by default
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/process/src/dslContext.ts | Core implementation of DSL parser and serializer functions |
| plugins/process/src/utils.ts | Added DSL fallback parsing when JSON fails |
| plugins/process/src/index.ts | Exported DSL context functionality |
| plugins/process/src/tests/dslContext.test.ts | Comprehensive test suite for DSL roundtrip functionality |
| plugins/process/docs/dsl.md | Complete documentation of DSL syntax and usage |
| plugins/process-resources/src/components/ProcessAttribute.svelte | Updated to use DSL format with JSON fallback |
| plugins/process-resources/src/components/attributeEditors/ConfigurePopup.svelte | Enhanced function filtering logic |
| plugins/process-resources/package.json | Added test scripts |
| packages/platform/src/index.ts | Exposed ident module for parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
haiodo
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSL for SelectedContext. As part of preparation for process dsl and for calculating fields separation. Why we need it? Because old way (JSON) was too big, especially for nested context (real example part on screenshot)
