Fix subscribe initial state, fix switch workspace error, upgrade ping#10026
Merged
Fix subscribe initial state, fix switch workspace error, upgrade ping#10026
Conversation
|
Connected to Huly®: UBERF-13868 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the HulypulseClient with improved subscription initialization, better error handling, and code cleanup. The changes focus on fixing subscription initial state delivery and addressing workspace switching errors through more robust reconnection logic.
- Added forced initialization for subscriptions to send all current variables to callbacks on subscription
- Implemented smoother error handling with automatic reconnection instead of throwing errors
- Cleaned up commented code and improved code consistency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Leonid Kaganov <lleo@lleo.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aonnikov
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added forced initialization (sending all currently available variables to the callback) on subscription, except for those whose expires will end within the next second — for atomicity.
Implemented smoother error handling and reconnection logic — hopefully, our infamous workspace error is finally gone.
Removed redundant ping when variables are already being sent. Need to remember to check the server behavior for this case.