Conversation
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new createContext function that provides a safe wrapper around createDSLContext, standardizing context creation throughout the codebase. The wrapper function catches exceptions and falls back to JSON stringification when DSL context creation fails.
- Adds a new
createContextwrapper function that handles errors gracefully - Replaces manual JSON stringification patterns with the new wrapper function
- Consolidates context creation logic across multiple Svelte components
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/process/src/dslContext.ts | Introduces the new createContext wrapper function |
| plugins/process-resources/src/utils.ts | Replaces manual JSON stringification with createContext |
| plugins/process-resources/src/components/criterias/RangeCriteria.svelte | Updates context creation to use new wrapper function |
| plugins/process-resources/src/components/criterias/BaseCriteriaEditor.svelte | Updates context creation to use new wrapper function |
| plugins/process-resources/src/components/criterias/ArraySizeCriteria.svelte | Updates context creation to use new wrapper function |
| plugins/process-resources/src/components/contextEditors/ToDoContextSelector.svelte | Refactors inline context creation to use new wrapper function |
| plugins/process-resources/src/components/ProcessAttribute.svelte | Replaces try-catch block with new wrapper function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Connected to Huly®: UBERF-13870 |
haiodo
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.