Conversation
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-13888 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds dead letter queue (DLQ) functionality for the fulltext service to handle transaction processing failures.
- Introduces a utility function to generate dead letter queue topic names
- Adds a dead letter producer to the WorkspaceManager for failed transactions
- Wraps transaction processing in try-catch block to route failures to DLQ
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/core/src/queue/utils.ts | Adds utility function to generate dead letter topic names |
| server/core/src/queue/index.ts | Exports the new utils module |
| pods/fulltext/src/manager.ts | Integrates DLQ producer and error handling for transaction processing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
haiodo
approved these changes
Oct 8, 2025
Contributor
|
@lexiv0re Please also send an error to telemetry using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.