feat: replace translate boilerplate with extension in editor#10054
Merged
feat: replace translate boilerplate with extension in editor#10054
Conversation
|
Connected to Huly®: UBERF-13898 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the manual translation boilerplate for editor placeholders with a new I18nPlaceholderExtension that automatically handles internationalization. The extension manages placeholder translations reactively, subscribing to theme store changes for language updates.
- Removed manual translation logic from editor components
- Created a new I18nPlaceholderExtension that extends the TipTap Placeholder extension
- Updated editor kit to use the new internationalized placeholder extension
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/text-editor-resources/src/kits/editor-kit.ts | Replaced Placeholder import with I18nPlaceholderExtension and updated the kit configuration |
| plugins/text-editor-resources/src/components/extension/i18nPlaceholder.ts | New extension that handles automatic translation of placeholders with theme store subscription |
| plugins/text-editor-resources/src/components/TextEditor.svelte | Removed manual translation logic and updated to use new extension options |
| plugins/text-editor-resources/src/components/CollaborativeTextEditor.svelte | Removed manual translation logic, cleaned up unused imports, and updated placeholder configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
plugins/text-editor-resources/src/components/extension/i18nPlaceholder.ts
Show resolved
Hide resolved
plugins/text-editor-resources/src/components/extension/i18nPlaceholder.ts
Show resolved
Hide resolved
plugins/text-editor-resources/src/components/CollaborativeTextEditor.svelte
Show resolved
Hide resolved
lexiv0re
previously approved these changes
Oct 9, 2025
a55b776 to
c921ac8
Compare
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
c921ac8 to
b0f818a
Compare
lexiv0re
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.