CLI argument sanitizing: removing trailing slashes in the server URL.#10080
Merged
GeneralGDA merged 2 commits intodevelopfrom Oct 14, 2025
Merged
CLI argument sanitizing: removing trailing slashes in the server URL.#10080GeneralGDA merged 2 commits intodevelopfrom
GeneralGDA merged 2 commits intodevelopfrom
Conversation
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves server URL handling by implementing consistent sanitization to remove trailing slashes from URLs before storage. This ensures that URLs are consistently formatted regardless of how they're input.
- Refactored URL reading logic to apply sanitization to all URL sources including existing saved URLs
- Added URL sanitization functionality that removes trailing slashes using a while loop
- Enhanced test coverage with parameterized tests to verify trailing slash removal behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| desktop/src/main/settings.ts | Added URL sanitization logic and refactored URL reading to consistently apply sanitization |
| desktop/src/test/main/settings.test.ts | Updated tests to use parameterized approach testing various trailing slash scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ArtyomSavchenko
approved these changes
Oct 14, 2025
haiodo
approved these changes
Oct 14, 2025
|
Connected to Huly®: UBERF-13931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and testing of server URLs in the application settings. The main focus is on ensuring that trailing slashes are consistently removed from server URLs before storing them, and updating the corresponding tests to verify this behavior.
Settings logic improvements:
setServerUrlmethod insettings.tsto remove any trailing slashes from the providedserverUrlbefore storing it, ensuring consistent URL formatting.Test enhancements:
setServerUrltests insettings.test.tsto use parameterized tests (test.each) with various forms of server URLs containing trailing slashes, verifying that the stored URL is always normalized.