Use navigation by types instead of spaces#10083
Merged
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements navigation by types instead of spaces for the card plugin, shifting from space-based navigation to type-based navigation using card types (MasterTag).
- Adds
GroupsNavModelinterface to support type-based navigation structure - Creates new
TypesNavigatorcomponent to display card types hierarchically - Updates routing logic to handle type-based URLs (
/card/type/{typeId})
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/workbench/src/types.ts | Defines new GroupsNavModel interface and extends navigation models |
| plugins/workbench-resources/src/components/Workbench.svelte | Adds support for finding specials within groups |
| plugins/workbench-resources/src/components/Navigator.svelte | Renders group components in navigation |
| plugins/card-resources/src/utils.ts | Updates routing logic to handle type navigation |
| plugins/card-resources/src/plugin.ts | Adds TypesNavigator component export |
| plugins/card-resources/src/index.ts | Registers TypesNavigator component |
| plugins/card-resources/src/components/navigator/TypesNavigator.svelte | New component for type-based navigation |
| plugins/card-resources/src/components/navigator/TagHierarchy.svelte | Updates to support both space and type selection |
| plugins/card-resources/src/components/Main.svelte | Updates to handle type-based navigation |
| plugins/card-resources/src/components/CardFeedView.svelte | Improves space handling for type-based views |
| models/card/src/index.ts | Configures navigation model to use groups instead of spaces |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Member
|
Do we need top-level section |
Member
Author
Do you mean add a section for types next to |
Member
Member
Author
haiodo
approved these changes
Oct 14, 2025
|
Connected to Huly®: UBERF-13924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading. Please reload this page.