Merged
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-14183 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the duplicated inbox app issue by conditionally rendering inbox apps based on whether the communication feature is enabled. When communication is disabled, it shows the legacy notification-based inbox (notificationId), and when enabled, it shows the modern communication-based inbox (inboxId). The inbox model is marked as hidden: true to prevent automatic rendering through the Applications component, while Workbench manually renders it conditionally.
Key Changes
- Added conditional rendering logic in Workbench.svelte to show the appropriate inbox app based on
isCommunicationEnabledflag - Set inbox model's
hiddenfield totrueto prevent duplication in the app list - Added
createNotificationsQuery()for modern inbox notification counting when communication is enabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/workbench-resources/src/components/Workbench.svelte | Implements conditional inbox rendering logic based on communication feature flag, adds notification query for unread count tracking, and updates props/navigation to use dynamic inbox ID |
| models/inbox/src/index.ts | Sets inbox app as hidden in model to prevent automatic rendering through Applications component |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
requested review from
BykhovDenis,
GeneralGDA,
aonnikov and
lexiv0re
lexiv0re
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.