Do not spam Uptrace with expected invite errors#10241
Merged
ArtyomSavchenko merged 1 commit intodevelopfrom Nov 22, 2025
Merged
Do not spam Uptrace with expected invite errors#10241ArtyomSavchenko merged 1 commit intodevelopfrom
ArtyomSavchenko merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-14216 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes three Analytics.handleError() calls from expected invite validation errors in the checkInvite function to prevent spamming Uptrace (the error monitoring service) with errors that are expected business logic validation failures.
- Removes error tracking for invite limit exceeded, expired invite links, and email mismatch validation errors
- Retains
ctx.error()logging for all validation failures - Aligns error handling with the codebase pattern where
Analytics.handleError()is reserved for unexpected errors only
Comments suppressed due to low confidence (1)
server/account/src/utils.ts:1125
- The commented-out code at line 1124 still contains
Analytics.handleError()for an expected validation error. If this code is ever re-enabled, theAnalytics.handleError()call should be removed to maintain consistency with the changes in this PR.
// ctx.error("Invite doesn't allow this email address", { email, ...invite })
// Analytics.handleError(new Error(`Invite link email mask check failed ${invite.id} ${email} ${invite.emailPattern}`))
// throw new PlatformError(new Status(Severity.ERROR, platform.status.Forbidden, {}))
BykhovDenis
approved these changes
Nov 22, 2025
ArtyomSavchenko
added a commit
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.