Skip to content

Fix default null value #10409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArtyomSavchenko merged 1 commit into from
Jan 16, 2026
Merged

Fix default null value #10409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foundations/core/packages/core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export function fillDefaults<T extends Doc> (
const baseClass = hierarchy.isDerived(_class, core.class.AttachedDoc) ? core.class.AttachedDoc : core.class.Doc
const attributes = hierarchy.getAllAttributes(_class, baseClass)
for (const attribute of attributes) {
if (attribute[1].defaultValue !== undefined) {
if (attribute[1].defaultValue != null) {
if ((object as any)[attribute[0]] === undefined) {
// Clone default value as it might be an object (e.g. array)
;(object as any)[attribute[0]] = structuredClone(attribute[1].defaultValue)
Expand Down
21 changes: 14 additions & 7 deletions models/server-process/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,15 +306,17 @@ export function createModel (builder: Builder): void {
txMatch: {
_class: core.class.TxCreateDoc,
objectClass: process.class.ProcessCustomEvent
}
},
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnExecutionRemove,
txMatch: {
_class: core.class.TxRemoveDoc,
objectClass: process.class.Execution
}
},
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
Expand All @@ -340,37 +342,42 @@ export function createModel (builder: Builder): void {
txMatch: {
_class: { $in: [core.class.TxUpdateDoc, core.class.TxMixin] },
objectClass: cardPlugin.class.Card
}
},
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnProcessRemove,
txMatch: {
_class: core.class.TxRemoveDoc,
objectClass: process.class.Process
}
},
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnStateRemove,
txMatch: {
_class: core.class.TxRemoveDoc,
objectClass: process.class.State
}
},
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnTransition,
txMatch: {
objectClass: process.class.Transition
}
},
isAsync: true
})

builder.createDoc(serverCore.class.Trigger, core.space.Model, {
trigger: serverProcess.trigger.OnCardCreate,
txMatch: {
_class: core.class.TxCreateDoc,
objectClass: cardPlugin.class.Card
}
},
isAsync: true
})
}
Loading