fix(account): handle empty $in array to prevent PostgreSQL IN () syntax error#10554
Merged
ArtyomSavchenko merged 2 commits intohcengineering:developfrom Feb 25, 2026
Merged
Conversation
…SQL syntax error buildWhereClause now emits FALSE for empty $in arrays instead of invalid IN () syntax. Also adds an early return in getWorkspacesInfoWithStatusByIds so callers like the GitHub/Gmail/Backup services never hit the query with an empty uuid list. Fixes hcengineering#10553 Signed-off-by: Yulian Diaz <5605867+spatialy@users.noreply.github.com>
|
Connected to Huly®: UBERF-15673 |
Contributor
Author
|
@ArtyomSavchenko, this is preventing GitHub sync from working properly in the latest version deployed with Postgres. Can you check? |
aonnikov
approved these changes
Feb 25, 2026
ArtyomSavchenko
approved these changes
Feb 25, 2026
…WithStatusByIds Per review feedback from @ArtyomSavchenko: use Array.isArray() in addition to the length check to handle runtime cases where uuids may not be an array. Signed-off-by: Yulian Diaz <5605867+spatialy@users.noreply.github.com>
ArtyomSavchenko
merged commit 66deebd
into
hcengineering:develop
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildWhereClause(postgres.ts), emitFALSEwhen a$inarray is empty instead of generating invalidIN ()SQL that PostgreSQL rejects with a syntax error.getWorkspacesInfoWithStatusByIds(utils.ts), add an earlyreturn []whenuuidsis empty so callers (GitHub, Gmail, Backup services) never reach the query with an empty list.Fixes #10553
Test plan
IN ()error no longer appears in account logs every ~6 minutes.getWorkspacesInforeturns[]when called with an empty id array instead of throwing a PostgreSQL syntax error.