Office: use pulse for invites and join requests#9941
Merged
Conversation
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
|
Connected to Huly®: UBERF-13778 |
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com> # Conflicts: # plugins/love-resources/package.json # plugins/love-resources/src/components/ActiveInvitesPopup.svelte # plugins/love-resources/src/components/InvitePopup.svelte # plugins/love-resources/src/components/PersonActionPopup.svelte # plugins/love-resources/src/components/RequestPopup.svelte # plugins/love-resources/src/components/RequestingPopup.svelte # plugins/love-resources/src/components/meeting/ControlExt.svelte # plugins/love-resources/src/components/meeting/invites/ActiveInvitesPopup.svelte # plugins/love-resources/src/components/meeting/invites/InviteEmployeeButton.svelte # plugins/love-resources/src/components/meeting/invites/InvitePopup.svelte # plugins/love-resources/src/components/meeting/invites/InviteRequestPopup.svelte # plugins/love-resources/src/components/meeting/invites/InviteResponsePopup.svelte # plugins/love-resources/src/components/meeting/invites/JoinRequestPopup.svelte # plugins/love-resources/src/components/meeting/invites/JoinResponsePopup.svelte # plugins/love-resources/src/components/meeting/invites/RequestPopup.svelte # plugins/love-resources/src/components/meeting/invites/RequestingPopup.svelte # plugins/love-resources/src/meetings.ts # plugins/love-resources/src/utils.ts
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the Love plugin's invite system to replace database-based join requests and invites with real-time pulse notifications. This change improves performance and reduces database load by migrating from persistent storage to ephemeral pulse-based communication.
Key changes:
- Replaces database-persisted JoinRequest and Invite classes with pulse-based messaging
- Migrates join request and invite handling from server triggers to client-side pulse communication
- Consolidates pulse client functionality in the presentation package
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server-plugins/love/src/index.ts | Removes OnInvite trigger registration |
| server-plugins/love-resources/src/index.ts | Removes database-based invite/join request handling functions and trigger exports |
| plugins/presence-resources/src/*.ts | Updates imports to use centralized pulse client from presentation package |
| plugins/love/src/types.ts | Removes database model definitions for JoinRequest and Invite |
| plugins/love/src/plugin.ts | Removes class references for JoinRequest and Invite |
| plugins/love-resources/src/joinRequests.ts | New file implementing pulse-based join request functionality |
| plugins/love-resources/src/invites.ts | New file implementing pulse-based invite functionality |
| plugins/love-resources/src/meetings.ts | Refactors meeting functions to use new pulse-based system |
| plugins/love-resources/src/components/meeting/invites/*.svelte | Updates UI components to work with new pulse-based data structures |
| packages/presentation/src/pulse.ts | Fixes import path for presentation plugin |
| packages/ui/src/popups.ts | Fixes popup update function to properly pass props |
Comments suppressed due to low confidence (1)
plugins/love-resources/src/components/meeting/invites/InviteResponsePopup.svelte:1
- The property name
inviteis inconsistent with the component's export parameter which expectsinvite: InviteRequest. The update should use consistent naming.
<!--
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Member
|
Please do not merge until Monday, don't want this to get into prod yet :) |
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com> # Conflicts: # plugins/love-resources/src/components/meeting/invites/InviteEmployeeButton.svelte # plugins/love-resources/src/utils.ts
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
aonnikov
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.