Improve configuration user experience #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on if configured as AP or client, some entries in page 2 make sense to be configured. I.e. the use of a DHCP makes only sense when it is a client and selecting the channel only makes sense when it is an AP. Further, when in client mode and with enabled DHCP, configuration of IP etc. doesn't make sense.
SumolX
reviewed
Nov 20, 2023
Member
|
page_storage: When |
Contributor
Author
Fixed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the user experience when configuring the goggles. It adds kind of an
enabledstate for configuration items. That means, when an item is configured to be disabled, navigation skips this item and its text is displayed in a darker shade.Further, when the first item in a page is disabled or only a label (for which the selection item should be set to disabled), it is skipped when entering that page.
What pages have been changed
In detail the following pages' configuration items are affected:
Batterycell label is not selectableCell Countslider can only be modified ifCell Count ModeisManualSide Fansslider can only be modified ifAuto ControlisOffAudio Sourcecan only be switched ifRecord AudioisOnDefaultselection spans two rows. They are now both highlighted as if they were oneBackpackisOff, no action can be taken in this page except for turning it onAPmode,DHCPandDNScannot be switchedClientmode,RF Channelcan never be modified andIP-relatedNetmaskandGatewaysettings can only be changed ifDHCPisOffTrackingisOff, no action can be taken in this page except for tuning it onEdit 2023-11-30:
develop.shorHDZGOGGLEfiles are detected on sd card, all options are disabledExample
The Fans page as an example:
Disabled
Side FanssliderEnabled
Side Fansslider