knative: implement dynamic sidebar filtering based on CRD discovery#720
Open
Joshna907 wants to merge 1 commit into
Open
knative: implement dynamic sidebar filtering based on CRD discovery#720Joshna907 wants to merge 1 commit into
Joshna907 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds cluster-aware sidebar filtering for the Knative plugin so the Knative menu can be hidden when the active cluster does not expose Knative Serving CRDs.
Changes:
- Adds CRD discovery state, TTL caching, and in-flight tracking for Knative installation checks.
- Registers a sidebar entry filter that hides the Knative parent and children when Knative is detected as absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
illume
reviewed
May 18, 2026
Signed-off-by: Joshna907 <joshnawaikar@gmail.com>
b8e00bb to
369babd
Compare
Contributor
Author
|
ptal now @illume |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Knative plugin's menu registration in the sidebar to implement dynamic, cluster-aware visibility filtering. It hides the entire Knative menu group when connected to a cluster where Knative's Serving components are not installed, matching Headlamp's visual quality standards.
Key changes
K8s,Utils, andregisterSidebarEntryFilterfrom the plugin SDK.checkKnativeInstalled(cluster)with a lightweight caching and time-to-live (TTL) mechanism to search the cluster's Custom Resource Definitions (CRDs) for'services.serving.knative.dev'.knativeparent and all child entries if Knative is not installed on the active cluster.Why this is needed
Steps to test