cmake: Fix test/config.ini generation#109
Merged
Merged
Conversation
Fix typos.
Fix a typo.
hebasto
commented
Mar 2, 2024
| set_configure_variable(WITH_ZMQ ENABLE_ZMQ) | ||
| set_configure_variable(ENABLE_EXTERNAL_SIGNER ENABLE_EXTERNAL_SIGNER) | ||
| set_configure_variable(ENABLE_TRACING ENABLE_USDT_TRACEPOINTS) | ||
| set_configure_variable(WITH_EXTERNAL_SIGNER ENABLE_EXTERNAL_SIGNER) |
Owner
Author
|
Friendly ping @vasild @TheCharlatan @theuni @pablomartin4btc @m3dwards @stickies-v :) |
pablomartin4btc
approved these changes
Mar 2, 2024
pablomartin4btc
left a comment
pablomartin4btc
left a comment
There was a problem hiding this comment.
crACK & tACK 94ea7fd
cat build/test/config.ini
...
[components]
# Which components are enabled. These are commented out by `configure` if they were disabled when running config.
ENABLE_WALLET=true
USE_SQLITE=true
#USE_BDB=true
ENABLE_CLI=true
ENABLE_BITCOIN_UTIL=true
ENABLE_WALLET_TOOL=true
ENABLE_BITCOIND=true
ENABLE_FUZZ_BINARY=true
ENABLE_ZMQ=true
#ENABLE_EXTERNAL_SIGNER=true
ENABLE_USDT_TRACEPOINTS=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed this bug during extensive testing in different scenarios after the recent sync.
Should be trivial to review and test by observing the content of the generated
test/config.inifile in the build directory.