cmake: Switch from tri-state options to boolean. Stage THREE#164
Merged
Conversation
Owner
Author
|
cc @achow101 |
hebasto
force-pushed
the
240422-cmake-DY
branch
from
7543f21 to
fb3318b
Compare
hebasto
added a commit
that referenced
this pull request
May 1, 2024
5de23c7 fixup! cmake: Add preset for MSVC build (Hennadii Stepanov) 09b1d5b fixup! ci: Test CMake edge cases (Hennadii Stepanov) 820a538 cmake [KILL 3-STATE]: Switch `WITH_QRENCODE` to boolean w/ default ON (Hennadii Stepanov) 017aeda cmake [FIXUP]: Move `find_program(brew)` out from introspection file (Hennadii Stepanov) Pull request description: This PR is a continuation of #161, #162 and #164 and tackles with the `WITH_QRENCODE` options. It becomes enabled when building GUI with the default value `ON`. Top commit has no ACKs. Tree-SHA512: 9cd923ef89e0a485330205db4389e42c001cbd6683a14b1e0c665d8e790e8bb2cae7b8b1929818443aea8eb5cbf6cafa79f4e44f41a893f54a5cdc09abc49dc1
Owner
Author
|
Rebased. |
sedited
approved these changes
May 4, 2024
| ) | ||
| if(WARN_INCOMPATIBLE_BDB) | ||
| message(WARNING "If this is intended, pass \"-DWARN_INCOMPATIBLE_BDB=OFF\".\n" | ||
| "Passing \"-DWITH_BDB=OFF\" will suppress this warning." |
There was a problem hiding this comment.
This was just moved from before, but it is kind of a weird suggestion to suppress something by switching of an entire feature.
Owner
Author
There was a problem hiding this comment.
It came from
bitcoin/build-aux/m4/bitcoin_find_bdb48.m4
Lines 48 to 66 in eb0bdbd
Any suggestions to improve the behavior?
`WITH_BDB` default is `OFF`.
Owner
Author
Sorry for rebasing. There was a conflict. Mind approving once more? |
sedited
approved these changes
May 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #161 and #162 and tackles with the
WITH_SQLITEandWITH_BDBoptions.For the latter the default value
OFFis suggested.The #83 (comment):
has been addressed.