Skip to content

cmake: Add WITH_DBUS configuration option#176

Merged
hebasto merged 1 commit into
cmake-stagingfrom
240428-cmake-EJ
May 8, 2024
Merged

cmake: Add WITH_DBUS configuration option#176
hebasto merged 1 commit into
cmake-stagingfrom
240428-cmake-EJ

Conversation

@hebasto
Copy link
Copy Markdown
Owner

@hebasto hebasto commented Apr 28, 2024

This PR adds a new WITH_DBUS configuration option, which is an analogue of Autotools' --with-qtdbus.

@hebasto hebasto added the enhancement New feature or request label Apr 28, 2024
@hebasto hebasto added this to the UI, 23th May milestone Apr 28, 2024
@fanquake
Copy link
Copy Markdown

Is this actually something we need (to port) an option for.

@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented Apr 28, 2024

Is this actually something we need (to port) an option for.

cc @laanwj

@laanwj
Copy link
Copy Markdown

laanwj commented Apr 28, 2024

Is this actually something we need (to port) an option for.

i think so. Not all UNIX platforms use DBUS. On Linux it's safe to assume it's there. On MacOS and Windows it's not a thing.

FWIW i tried to get rid of the custom notification stuff a while ago, but Qt's notificator still falls back to ancient X11 notifications which are ignored (or look very shitty) on modern Linux. Maybe qt6 changes this? i dunno. But for now t's really necessary.

@theuni
Copy link
Copy Markdown

theuni commented May 3, 2024

Should probably get rid of the HAVE_CONFIG_H (in qt/notificator.cpp) ?

@hebasto hebasto force-pushed the 240428-cmake-EJ branch from 5a85ac0 to ec486a3 Compare May 3, 2024 19:24
@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented May 3, 2024

Should probably get rid of the HAVE_CONFIG_H (in qt/notificator.cpp) ?

Sure. Removed.

@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented May 4, 2024

@theuni

Should probably get rid of the HAVE_CONFIG_H (in qt/notificator.cpp) ?

FWIW, #177 removes unsed HAVE_CONFIG_H in the entire codebase.

@hebasto hebasto force-pushed the 240428-cmake-EJ branch from ec486a3 to 7ab6bb3 Compare May 4, 2024 13:59
@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented May 4, 2024

Rebased.

@hebasto hebasto force-pushed the 240428-cmake-EJ branch from 7ab6bb3 to 4477453 Compare May 8, 2024 11:08
@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented May 8, 2024

Rebased on top of the merged #173.

Copy link
Copy Markdown

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebasto hebasto merged commit a38691b into cmake-staging May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants