cmake: Fix and improve CI#183
Merged
Merged
Conversation
Force build step to fail if build fails. Otherwise, the build step might falsely succeed because the last command exit code determines the return status of the step.
A workaround for a bug fixed in bitcoin#29963
Owner
Author
|
cc @m3dwards |
|
I see CI is green and I've reviewed the code. utACK 729632c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
falsely succeed because the last command exit code determines the return status of the step.
I've noticed such wrong behaviour while working on #182.