Skip to content

cmake, doc: Update build-unix.md#208

Merged
hebasto merged 1 commit into
cmake-stagingfrom
240522-cmake-FL
May 22, 2024
Merged

cmake, doc: Update build-unix.md#208
hebasto merged 1 commit into
cmake-stagingfrom
240522-cmake-FL

Conversation

@hebasto
Copy link
Copy Markdown
Owner

@hebasto hebasto commented May 22, 2024

No description provided.

@hebasto hebasto added the documentation Docs and manuals label May 22, 2024
Comment thread doc/build-unix.md Outdated
Copy link
Copy Markdown

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 52400af

Checked consistency also against #201.

@hebasto hebasto force-pushed the 240522-cmake-FL branch from 52400af to a11cb27 Compare May 22, 2024 11:32
@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented May 22, 2024

@pablomartin4btc's #208 (comment) has been addressed.

@pablomartin4btc
Copy link
Copy Markdown

re-ACK a11cb27

Comment thread doc/build-unix.md
Comment thread doc/build-unix.md
To build with GUI pass `-DBUILD_GUI=ON`.

To build with Qt 5 you need the following:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Once these are installed, they will be found by configure and a bitcoin-qt executable will be
built by default."

This is no longer true?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer true?

Please join the discussion in #196 :)

TL;DR:

During our calls, we discussed the concept of build options. We have reached a rough consensus to make them "opt-in" rather than "opt-out" as much as possible.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this being the case, shouldn't we delete the line: "Once these are installed, they will be found by configure and a bitcoin-qt executable will be built by default."

Copy link
Copy Markdown
Owner Author

@hebasto hebasto May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Deleted.

Comment thread doc/build-unix.md
@m3dwards
Copy link
Copy Markdown

Added some nits, two unrelated to the change to cmake.

@hebasto hebasto force-pushed the 240522-cmake-FL branch from a11cb27 to f09b76b Compare May 22, 2024 12:42
@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented May 22, 2024

@m3dwards's #208 (comment) has been addressed.

Copy link
Copy Markdown

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just left some comments.

Comment thread doc/build-unix.md
./configure
make # use "-j N" for N parallel jobs
make install # optional
cmake -B build
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we talked previously about adding -S to the docs whenever we are configuring, but I can't remember anymore what the verdict was.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. There was -S in the past. See:

We agreed to use modern CMake invocation style. Configuring in the source root makes the -S option redundant.

Comment thread doc/build-unix.md
@hebasto hebasto merged commit da4fefa into cmake-staging May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Docs and manuals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants