cmake: Fix hardening flags#211
Merged
Merged
Conversation
|
A few things:
|
Do not pass `-mbranch-protection=bti` during link stage.
hebasto
commented
May 24, 2024
Comment on lines
+508
to
+509
| $<$<NOT:$<CONFIG:Debug>>:-U_FORTIFY_SOURCE> | ||
| $<$<NOT:$<CONFIG:Debug>>:-D_FORTIFY_SOURCE=3> |
Owner
Author
There was a problem hiding this comment.
Dealing with an individual options within generator expressions is much easier.
Owner
Author
I left only this change, which effectively is pulled from the current #93.
I'll submit a demo branch shortly. |
Owner
Author
|
ACK e2f2f23 Tested with and without PR and can now see the hardening flag not being passed during linking on M1 Mac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing #93, a few issues were noticed:
The other change simplifies the summary code in #93.