[POC] cmake: Rework compile/link flags summary -- an alternative implemenation#218
Closed
hebasto wants to merge 2 commits into
Closed
[POC] cmake: Rework compile/link flags summary -- an alternative implemenation#218hebasto wants to merge 2 commits into
hebasto wants to merge 2 commits into
Conversation
384b398 to
b645a49
Compare
This change mirrors the master branch behavior.
b645a49 to
0ca886f
Compare
Owner
Author
|
Rebased. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative implementation of #93 and an attempt to address concerns regarding the summary accuracy and code maintainability.
The proposed approach guarantees 100% summary accuracy, including all known and future CMake abstractions.
However, the code still relies on CMake generators implementation details. This branch currently has implementations for the following generators:
The idea of such an approach was discussed during the call on 2024-05-30.