cmake: Report skipped tests properly#272
Merged
Merged
Conversation
Owner
Author
Owner
Author
|
From https://github.com/hebasto/bitcoin/actions/runs/10015755552/job/27687669760: |
maflcko
approved these changes
Jul 22, 2024
| @@ -39,6 +39,9 @@ if(TARGET test_bitcoin) | |||
| add_test(NAME ${test_suite_name} | |||
There was a problem hiding this comment.
Any reason to even support this? Seems fine to just let devs call $build_dir/test_bitcoin -t suite/case manually for now (just like in autotools)?
Owner
Author
There was a problem hiding this comment.
This allows leveraging parallelism when running ctest -j <number_of_jobs>. Basically, this mirrors the behaviour of make check in the master branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake allows to report about skipped tests properly instead of passing dummy test cases. For instance, on Windows:
We have 3 such cases:
src/test/compilerbug_tests.cppsrc/test/raii_event_tests.cppsrc/test/system_tests.cppThis PR handles the first two cases.
Once bitcoin#30454 is merged, the following lines can be deleted:
bitcoin/src/test/system_tests.cpp
Lines 19 to 25 in 9b4aa92