Skip to content

cmake, ci: Add 'Test dependency search' CI job#70

Merged
hebasto merged 1 commit into
cmake-stagingfrom
240108-cmake-AS
Jan 17, 2024
Merged

cmake, ci: Add 'Test dependency search' CI job#70
hebasto merged 1 commit into
cmake-stagingfrom
240108-cmake-AS

Conversation

@hebasto
Copy link
Copy Markdown
Owner

@hebasto hebasto commented Jan 8, 2024

I've been working on a branch, which adds Qt stuff to the CMake-based build system.

However, it is possible that the package search code refactoring will be needed. Therefore, I'd like to get these CI tests in the staging branch to avoid any regressions.

@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented Jan 9, 2024

Rebased.

Copy link
Copy Markdown

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ACK c9a63f9

Agree that this is useful now and can eventually be dropped again.

Add 'Test dependency search' CI job
@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented Jan 16, 2024

@TheCharlatan

lgtm ACK c9a63f9

Agree that this is useful now and can eventually be dropped again.

Sorry, but this branch had to be rebased on top of the #76.

@sedited
Copy link
Copy Markdown

sedited commented Jan 17, 2024

Re-ACK

@hebasto hebasto merged commit ea9b319 into cmake-staging Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants