Skip to content

Modified validator and EventManager to handle n/a in onset column #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 6 commits into from
Oct 11, 2024
Merged

Modified validator and EventManager to handle n/a in onset column #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52bac3d
Bump spec_tests/hed-examples from `f117c4d` to `ca307b9`
dependabot[bot] Oct 2, 2024
3a0eb55
Merge pull request #1024 from hed-standard/dependabot/submodules/deve…
VisLab Oct 7, 2024
fd3a572
Changed ONSETS_OUT_OF_ORDER to ONSETS_UNORDERED
VisLab Oct 8, 2024
a5b99e3
Preliminary handling of n/a onsets
VisLab Oct 11, 2024
9bf1089
Updated validator and EventManager to handle n/a onsets
VisLab Oct 11, 2024
bc8d750
Merge pull request #1028 from VisLab/clean-up
VisLab Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions hed/errors/error_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ def val_error_empty_group(tag):
return f"HED tags cannot be empty. Extra delimiters found: '{tag}'"


@hed_tag_error(TemporalErrors.HED_ONSET_WITH_NO_COLUMN, actual_code=ValidationErrors.TEMPORAL_TAG_ERROR)
def val_error_hed_onset_with_no_column(tag):
return f"Cannot have Temporal tags without an 'Onset' column. Found tag: '{tag}'"
@hed_tag_error(TemporalErrors.TEMPORAL_TAG_NO_TIME, actual_code=ValidationErrors.TEMPORAL_TAG_ERROR)
def val_error_temporal_tag_no_time(tag):
return f"Cannot have Temporal tags without an 'Onset' column and a time. Found tag: '{tag}'"


@hed_tag_error(ValidationErrors.TAG_EXTENDED, has_sub_tag=True, default_severity=ErrorSeverity.WARNING)
Expand Down Expand Up @@ -77,9 +77,9 @@ def val_error_CURLY_BRACE_UNSUPPORTED_HERE(tag, problem_tag):
f"Invalid character '{problem_tag}' in tag '{tag}'")


@hed_error(ValidationErrors.ONSETS_OUT_OF_ORDER, default_severity=ErrorSeverity.WARNING)
def val_error_ONSETS_OUT_OF_ORDER():
return "Onsets need to be temporally increasing for most downstream tools to work."
@hed_error(ValidationErrors.ONSETS_UNORDERED, default_severity=ErrorSeverity.WARNING)
def val_error_ONSETS_UNORDERED():
return "Onsets need to be temporally increasing and defined for many downstream tools to work."


@hed_error(ValidationErrors.COMMA_MISSING)
Expand Down
Loading