Skip to content

Fixed xml2schema extras input #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 1 commit into from
Apr 9, 2025
Merged

Fixed xml2schema extras input #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hed/schema/schema_io/wiki2schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def _parse_extras(self, wiki_lines_by_section):
if not data:
continue
df = pd.DataFrame(data).fillna('').astype(str)
self._schema.extras[extra_key] = df
self._schema.extras[extra_key.strip('"')] = df

@staticmethod
def parse_star_string(s):
Expand Down
8 changes: 5 additions & 3 deletions hed/schema/schema_io/xml2schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,13 @@ def _get_element_tag_value(self, element, tag_name=xml_constants.NAME_ELEMENT):
return element.text
return ""

def _get_element_value(self, element, tag_name):
if element is None or element.text is None:
@staticmethod
def _get_element_value(element, tag_name):
this_element = element.find(tag_name)
if this_element is None or this_element.text is None:
return ''
else:
return element.text
return this_element.text

def _get_elements_by_name(self, element_name='node', parent_element=None):
""" Get the elements that have a specific element name.
Expand Down