Merging the refactored model code into develop#638
Merged
Conversation
First pass refactor of models
Updated unit tests
Add some df tests. Update hed_assemble. Make the df utils also work on series.
Fixed some of the refactoring errors
Add more unit tests. better nan and empty column handling
Revert "Add more unit tests. better nan and empty column handling"
Update nan and empty column handling
Fixed more unit tests
Fix hed_string.expand_defs issue
Corrected some of the refactored unit tests
Updated bids tests
…#632) * Add squre bracket in column validation for spreadsheets. Update error handling slightly(error list is now sorted by context always) * Further fix shrinking/expanding(with some test cases). Start updating errors to spec names.
* Block HED from appearing in sidecars
Updated the search in analysis tools
Fix sorting for hed string context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges a major refactoring of the fundamental models to rely more heavily on Pandas DataFrame infrastructure and to more uniformly handle when schemas are used.