Skip to content

Fix saving library schemas lacking in the withStandard attribute. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 2 commits into from
May 26, 2023
Merged

Fix saving library schemas lacking in the withStandard attribute. #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a247921
Don't add the inLibrary attribute if no withStandard partner
IanCa May 25, 2023
045ee7f
Tweak another save merged spot
IanCa May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hed/schema/hed_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ def _get_attributes_for_section(self, key_class):
# ===============================================
def _add_tag_to_dict(self, long_tag_name, new_entry, key_class):
# No reason we can't add this here always
if self.library and not self.merged:
if self.library and not self.merged and self.with_standard:
new_entry.set_attribute_value(HedKey.InLibrary, self.library)

section = self._sections[key_class]
Expand Down
8 changes: 3 additions & 5 deletions hed/schema/schema_io/schema2base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,9 @@ def process_schema(self, hed_schema, save_merged=False):
self._save_base = True
else:
# Saving a standard schema or a library schema without a standard schema
save_merged = False
if hed_schema.library:
self._save_lib = True
else:
self._save_base = True
save_merged = True
self._save_lib = True
self._save_base = True
self._save_merged = save_merged


Expand Down