Skip to content

Silently ignore libraries with no hedxml folder #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 1 commit into from
Jun 8, 2023
Merged

Silently ignore libraries with no hedxml folder #681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions hed/schema/hed_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import json
from hashlib import sha1
from shutil import copyfile
import urllib
import re
from semantic_version import Version
import portalocker
Expand Down Expand Up @@ -371,9 +372,13 @@ def _get_hed_xml_versions_from_url(hed_base_url, library_name=None,
continue
if file_entry['name'] in skip_folders:
continue
sub_folder_versions = \
_get_hed_xml_versions_from_url(hed_base_url + "/" + file_entry['name'] + hedxml_suffix,
skip_folders=skip_folders, get_libraries=True)
try:
sub_folder_versions = \
_get_hed_xml_versions_from_url(hed_base_url + "/" + file_entry['name'] + hedxml_suffix,
skip_folders=skip_folders, get_libraries=True)
except urllib.error.HTTPError as e:
# Silently ignore ones without a hedxml section for now.
continue
_merge_in_versions(all_hed_versions, sub_folder_versions)
expression_match = version_pattern.match(file_entry["name"])
if expression_match is not None:
Expand Down