Skip to content

Fix bug in caching library schema #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 1 commit into from
Jun 12, 2023
Merged

Fix bug in caching library schema #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hed/schema/hed_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def get_hed_versions(local_hed_directory=None, library_name=None, get_libraries=
if expression_match is not None:
version = expression_match.group(3)
found_library_name = expression_match.group(2)
if found_library_name != library_name:
if not get_libraries and found_library_name != library_name:
continue
if found_library_name not in all_hed_versions:
all_hed_versions[found_library_name] = []
Expand Down
2 changes: 1 addition & 1 deletion tests/schema/test_hed_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def test_cache_specific_url(self):
def test_get_hed_versions_all(self):
cached_versions = hed_cache.get_hed_versions(self.hed_cache_dir, get_libraries=True)
self.assertIsInstance(cached_versions, dict)
self.assertTrue(len(cached_versions) > 0)
self.assertTrue(len(cached_versions) > 1)

def test_get_hed_versions(self):
cached_versions = hed_cache.get_hed_versions(self.hed_cache_dir)
Expand Down