Skip to content

Allow HED in sidecar lists again #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 1 commit into from
Oct 25, 2023
Merged

Allow HED in sidecar lists again #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions hed/validator/sidecar_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ def _check_dict(key, data_dict):
@staticmethod
def _check_list(key, data_list):
for sub_data in data_list:
if sub_data == key:
return True
if SidecarValidator._check_for_key(key, sub_data):
return True
return False
Expand Down
2 changes: 1 addition & 1 deletion tests/validator/test_sidecar_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,4 @@ def test_bad_structure_HED_in_ignored(self):
'''
sidecar = Sidecar(io.StringIO(sidecar_with_na_json))
issues = sidecar.validate(self.hed_schema)
self.assertEqual(len(issues), 3)
self.assertEqual(len(issues), 2)