[HOTFIX] make Reward optional in some cases#135
Merged
Conversation
Member
Author
|
due to the urgency of the issue (API is down) and unavailability of any other maintainers I'll be bypassing the review requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrowHead pushed an MO where the
Rewardfields arenullwhich causes the current serialization process to break; effectively forcing the API offline.This PR addresses the issue by updating the typing to account for this and will return an empty
Rewardslist (andnullforReward) if there's no rewards.While this is a breaking change, we don't have much choice between making up data or breaking the interface.