Major order task locations#94
Merged
dealloc merged 2 commits intohelldivers-2:masterfrom Jul 31, 2025
Merged
Conversation
Indicates whether the task refers to a planet or a sector (or potentially something else entirely).
Depending on the "location_type", this is the index of the planet or sector that the task refers to.
Member
|
given that updating the JSON files is a manual task and not an automatic dependency update, I feel breaking changes might be warranted if they allow for better/more accurate translation of the game's keys. Also, this is a value we're changing, not a key |
dealloc
approved these changes
Jul 31, 2025
dealloc
added a commit
to helldivers-2/api
that referenced
this pull request
Aug 1, 2025
dealloc
added a commit
to helldivers-2/api
that referenced
this pull request
Aug 1, 2025
dealloc
added a commit
to helldivers-2/api
that referenced
this pull request
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MO (2368689649) refers to a sector instead of a planet. Turns out the "planet_index" is more like a "location_index" whereas the "liberate" (value type 11) appears to indicate the type of location and is therefore renamed to "location_type" in this PR.
Renaming is a breaking change to anyone who relies on the value type's name, so renaming might not be an option and may have to be reverted / the PR rejected.