Properly decide terminal width on non-unix systems#23
Closed
xypwn wants to merge 1 commit intohellflame:masterfrom
Closed
Properly decide terminal width on non-unix systems#23xypwn wants to merge 1 commit intohellflame:masterfrom
xypwn wants to merge 1 commit intohellflame:masterfrom
Conversation
stty isn't available on Windows. This patch uses golang.org/x/term instead to determine the actual terminal width. This makes it work on Windows without issues.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Process
Before submitting a pull request
Be sure you have the latest code in hand. Pull the
masterbranchBe sure to
make testand keep all test passBe sure to
make tidyso your code style will keep the sameBe sure to
make cover-reportto see if any line not coveredDon't Rebase git history
General steps for completing this pull request
Checklist
Ensure that your
pull requesthas followed all the steps below:Description
stty isn't available on Windows. This patch uses golang.org/x/term instead to determine the actual terminal width. This makes it work on Windows without issues.
Proposed changes
This improves the UX on Windows, or any other system where the "stty" command may not be available.
Types of changes