Update ecc.py #17
Open
Update ecc.py #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file ecc.py was missing the important function of point negation. Without it, any practical application of this library in the part related to elliptic curves would be impossible.
Comments in ecc.py were slightly refined to better reflect their essence. The file README.md was updated in order to correspond to the contents of ecc.py.
Added a small clarification related to the multiplying of a point P by the number n when n is negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file ecc.py was missing the important function of point negation and multiplying the point to the negative number. Without it, any practical application of this library in the part related to elliptic curves would be limited if not impossible.