Conversation
Contributor
Author
|
Looks redundant w/ #334 |
Contributor
Author
|
Built on #334 |
lllleonnnn
reviewed
Mar 10, 2020
|
|
||
| cp -r /usr/src/cache/node_modules/. /usr/src/app/node_modules/ | ||
| # exec npm run build | ||
| exec npm run start-docker |
Contributor
There was a problem hiding this comment.
does using the entrypoint allow you to watch/rebuild during local development?
lllleonnnn
reviewed
Mar 10, 2020
| } else { | ||
| mongoose.connect(mongoUri, { useNewUrlParser: true }); | ||
| } | ||
| mongoose.connect(config.mongoUri, config.mongoOptions); |
lllleonnnn
reviewed
Mar 10, 2020
| }); | ||
| } | ||
| var sessionStore = new MongoStore({ | ||
| url: config.mongoUri, |
lllleonnnn
reviewed
Mar 10, 2020
| "seed": "mongoimport -c users --uri mongodb://localhost:27017/hellogov --drop --file conf/seeds.json", | ||
| "start": "NODE_ENV=production node index.js", | ||
| "start-dev": "NODE_ENV=development nodemon index.js", | ||
| "start-docker": "NODE_ENV=dev-docker nodemon index.js", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #326 (semi-related)
Motivation and context
To run end-to-end tests, we'll have to have a real instance of the app running. Docker will help simplify this process by handling the setup/build/running of the app. It will also make the development environments more consistent since everyone will run the same environment in a container.
What I did
Dockerfilefor the node webapp, which builds the dependencies in the container while keeping the code local to the host. This allowsnodemonto continue to work.dev-docker).Dockerfile.I'd like a reviewer to test running docker on their machine.