Revert recent changes to "required" properties#441
Merged
jtreminio-dropbox merged 1 commit intomainfrom Oct 18, 2024
Merged
Conversation
jtreminio-dropbox
added
SDK - Dotnet
erkkinen
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the following:
The plan is to test the listed changes and confirm that they do not negatively affect customers using the legacy SDKs. Once confirmed, re-merge the above.
Reasoning is, if we begin stating that any of the above fields are now required, but it breaks legacy SDK customers we would need to revert which would lead to breaking customers using any of the new SDKs!