Conditional query optimization? Does this break anything?#33
Open
followingthefasciaplane wants to merge 3 commits intohermansimensen:masterfrom
Open
Conversation
Do we need to be querying cvars that have no effect with m_rawinput 1 or joystick 0? Does this break anything?
Author
|
From my testing, everything seems to work fine. |
| } | ||
| if (g_JoyStickChangedCount[client] > 1) | ||
| { | ||
| PrintToAdmins("%N changed their joystick ConVar to %d", client, joyStick); |
There was a problem hiding this comment.
PrintToAdmins is missing "client" as the first param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of my other PR: #32
Do we need to be querying
m_customaccel,m_customaccel_exponent,m_customaccel_scale,m_customaccel_max,m_filterifm_rawinputis not 0? The values of these cvars do nothing ifm_rawinputis set to 1.Additionally, I have made
joy_yawsensitivityquerying conditional based onjoystick 1