Skip to content

fix(xtask): properly terminate children started with sudo#2299

Merged
mkroening merged 5 commits intomainfrom
sudo-kill
Mar 6, 2026
Merged

fix(xtask): properly terminate children started with sudo#2299
mkroening merged 5 commits intomainfrom
sudo-kill

Conversation

@mkroening
Copy link
Member

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 02aaae3 Previous: 93015ac Performance Ratio
startup_benchmark Build Time 89.26 s 87.93 s 1.02
startup_benchmark File Size 0.79 MB 0.79 MB 1.00
Startup Time - 1 core 0.96 s (±0.03 s) 0.94 s (±0.03 s) 1.01
Startup Time - 2 cores 0.97 s (±0.04 s) 0.96 s (±0.03 s) 1.01
Startup Time - 4 cores 0.95 s (±0.03 s) 0.97 s (±0.03 s) 0.98
multithreaded_benchmark Build Time 87.74 s 86.34 s 1.02
multithreaded_benchmark File Size 0.89 MB 0.89 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 89.20 % (±7.74 %) 88.79 % (±8.25 %) 1.00
Multithreaded Pi Efficiency - 4 Threads 44.56 % (±3.43 %) 44.06 % (±3.70 %) 1.01
Multithreaded Pi Efficiency - 8 Threads 25.67 % (±1.62 %) 25.76 % (±2.11 %) 1.00
micro_benchmarks Build Time 98.39 s 95.46 s 1.03
micro_benchmarks File Size 0.90 MB 0.90 MB 1.00
Scheduling time - 1 thread 73.22 ticks (±4.31 ticks) 70.19 ticks (±3.78 ticks) 1.04
Scheduling time - 2 threads 39.61 ticks (±5.57 ticks) 38.82 ticks (±5.94 ticks) 1.02
Micro - Time for syscall (getpid) 3.06 ticks (±0.24 ticks) 2.87 ticks (±0.22 ticks) 1.07
Memcpy speed - (built_in) block size 4096 63617.74 MByte/s (±45155.97 MByte/s) 65241.09 MByte/s (±46657.58 MByte/s) 0.98
Memcpy speed - (built_in) block size 1048576 29474.86 MByte/s (±24587.82 MByte/s) 29624.28 MByte/s (±24505.93 MByte/s) 0.99
Memcpy speed - (built_in) block size 16777216 25459.34 MByte/s (±21466.56 MByte/s) 28063.32 MByte/s (±23395.83 MByte/s) 0.91
Memset speed - (built_in) block size 4096 64060.33 MByte/s (±45467.70 MByte/s) 65701.33 MByte/s (±46939.48 MByte/s) 0.98
Memset speed - (built_in) block size 1048576 30324.36 MByte/s (±25076.31 MByte/s) 30429.97 MByte/s (±24974.64 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 26235.23 MByte/s (±21940.18 MByte/s) 28864.03 MByte/s (±23869.04 MByte/s) 0.91
Memcpy speed - (rust) block size 4096 56153.78 MByte/s (±41068.06 MByte/s) 60526.81 MByte/s (±44630.65 MByte/s) 0.93
Memcpy speed - (rust) block size 1048576 29603.17 MByte/s (±24702.55 MByte/s) 29406.90 MByte/s (±24399.64 MByte/s) 1.01
Memcpy speed - (rust) block size 16777216 24650.91 MByte/s (±20707.31 MByte/s) 28159.49 MByte/s (±23489.43 MByte/s) 0.88
Memset speed - (rust) block size 4096 57240.44 MByte/s (±41862.20 MByte/s) 61485.78 MByte/s (±45322.49 MByte/s) 0.93
Memset speed - (rust) block size 1048576 30416.23 MByte/s (±25159.16 MByte/s) 30190.72 MByte/s (±24863.80 MByte/s) 1.01
Memset speed - (rust) block size 16777216 25422.55 MByte/s (±21210.71 MByte/s) 28941.68 MByte/s (±23945.25 MByte/s) 0.88
alloc_benchmarks Build Time 97.67 s 97.71 s 1.00
alloc_benchmarks File Size 0.86 MB 0.86 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 9194.84 Ticks (±163.70 Ticks) 11682.50 Ticks (±310.03 Ticks) 0.79
Allocations - Average Allocation time (no fail) 9194.84 Ticks (±163.70 Ticks) 11682.50 Ticks (±310.03 Ticks) 0.79
Allocations - Average Deallocation time 2627.77 Ticks (±1240.00 Ticks) 1012.52 Ticks (±456.95 Ticks) 2.60
mutex_benchmark Build Time 98.78 s 92.91 s 1.06
mutex_benchmark File Size 0.90 MB 0.90 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 13.90 ns (±0.81 ns) 12.92 ns (±0.56 ns) 1.08
Mutex Stress Test Average Time per Iteration - 2 Threads 25.64 ns (±18.42 ns) 20.44 ns (±8.04 ns) 1.25

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening changed the title fix(xtask): properly kill children started with sudo fix(xtask): properly terminate children started with sudo Mar 6, 2026
@mkroening mkroening added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit 6fbe1ce Mar 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant