Skip to content

fix(fs/uhyve): Mount all uhyve directories#2301

Open
fogti wants to merge 1 commit intohermit-os:mainfrom
fogti:fs-mount-all-uhyve
Open

fix(fs/uhyve): Mount all uhyve directories#2301
fogti wants to merge 1 commit intohermit-os:mainfrom
fogti:fs-mount-all-uhyve

Conversation

@fogti
Copy link
Contributor

@fogti fogti commented Mar 6, 2026

This fixes a problem encountered in hermit-os/uhyve#1287

@n0toose
Copy link
Member

n0toose commented Mar 6, 2026

If a success occurs, nothing further is mounted because we return from within the loop.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: cc00a35 Previous: 6fbe1ce Performance Ratio
startup_benchmark Build Time 87.58 s 96.31 s 0.91
startup_benchmark File Size 0.79 MB 0.79 MB 1.00
Startup Time - 1 core 0.94 s (±0.04 s) 0.97 s (±0.02 s) 0.97
Startup Time - 2 cores 0.96 s (±0.03 s) 0.94 s (±0.03 s) 1.02
Startup Time - 4 cores 0.96 s (±0.03 s) 0.95 s (±0.04 s) 1.01
multithreaded_benchmark Build Time 85.24 s 87.98 s 0.97
multithreaded_benchmark File Size 0.90 MB 0.89 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 90.06 % (±9.10 %) 89.46 % (±7.87 %) 1.01
Multithreaded Pi Efficiency - 4 Threads 44.33 % (±3.07 %) 44.11 % (±2.93 %) 1.01
Multithreaded Pi Efficiency - 8 Threads 25.85 % (±2.06 %) 25.80 % (±1.85 %) 1.00
micro_benchmarks Build Time 93.78 s 94.40 s 0.99
micro_benchmarks File Size 0.90 MB 0.90 MB 1.00
Scheduling time - 1 thread 69.79 ticks (±4.06 ticks) 69.95 ticks (±4.70 ticks) 1.00
Scheduling time - 2 threads 38.44 ticks (±4.38 ticks) 38.83 ticks (±4.55 ticks) 0.99
Micro - Time for syscall (getpid) 3.01 ticks (±0.28 ticks) 2.98 ticks (±0.27 ticks) 1.01
Memcpy speed - (built_in) block size 4096 64385.79 MByte/s (±45555.18 MByte/s) 64182.13 MByte/s (±45844.02 MByte/s) 1.00
Memcpy speed - (built_in) block size 1048576 29558.67 MByte/s (±24429.59 MByte/s) 29093.31 MByte/s (±24184.81 MByte/s) 1.02
Memcpy speed - (built_in) block size 16777216 28208.31 MByte/s (±23534.10 MByte/s) 27668.76 MByte/s (±23025.15 MByte/s) 1.02
Memset speed - (built_in) block size 4096 65131.96 MByte/s (±46012.86 MByte/s) 64488.80 MByte/s (±46048.46 MByte/s) 1.01
Memset speed - (built_in) block size 1048576 30339.46 MByte/s (±24870.72 MByte/s) 29922.54 MByte/s (±24669.33 MByte/s) 1.01
Memset speed - (built_in) block size 16777216 28963.43 MByte/s (±23955.53 MByte/s) 28393.24 MByte/s (±23430.43 MByte/s) 1.02
Memcpy speed - (rust) block size 4096 60727.72 MByte/s (±44541.85 MByte/s) 58670.65 MByte/s (±43230.84 MByte/s) 1.04
Memcpy speed - (rust) block size 1048576 29560.68 MByte/s (±24463.63 MByte/s) 29144.45 MByte/s (±24221.61 MByte/s) 1.01
Memcpy speed - (rust) block size 16777216 28275.43 MByte/s (±23584.08 MByte/s) 27598.46 MByte/s (±22957.54 MByte/s) 1.02
Memset speed - (rust) block size 4096 61579.39 MByte/s (±45043.46 MByte/s) 59761.33 MByte/s (±44002.85 MByte/s) 1.03
Memset speed - (rust) block size 1048576 30331.41 MByte/s (±24909.42 MByte/s) 29947.21 MByte/s (±24693.66 MByte/s) 1.01
Memset speed - (rust) block size 16777216 29013.33 MByte/s (±23988.10 MByte/s) 28349.48 MByte/s (±23394.89 MByte/s) 1.02
alloc_benchmarks Build Time 93.51 s 92.67 s 1.01
alloc_benchmarks File Size 0.86 MB 0.86 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 9357.80 Ticks (±153.77 Ticks) 9308.47 Ticks (±140.81 Ticks) 1.01
Allocations - Average Allocation time (no fail) 9357.80 Ticks (±153.77 Ticks) 9308.47 Ticks (±140.81 Ticks) 1.01
Allocations - Average Deallocation time 3823.99 Ticks (±267.99 Ticks) 1031.43 Ticks (±717.26 Ticks) 3.71
mutex_benchmark Build Time 92.47 s 94.39 s 0.98
mutex_benchmark File Size 0.90 MB 0.90 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 13.22 ns (±0.78 ns) 13.14 ns (±0.69 ns) 1.01
Mutex Stress Test Average Time per Iteration - 2 Threads 19.32 ns (±7.41 ns) 21.28 ns (±11.81 ns) 0.91

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants