fix: install cli on ubuntu 25.04 without using apt-key #3315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
approved these changes
Jun 13, 2025
This was referenced Jun 19, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the Heroku CLI installation process in
install-ubuntu.shto improve compatibility with newer versions of Ubuntu. It replaces the deprecated apt-key method with a conditional approach: if apt-key is available, it is used; otherwise, the script installs the GPG package, converts the release key to GPG format, and configures the repository to use the keyring method. This ensures the script works on both older and newer Ubuntu systems.Risk
Low. The changes are limited to the Heroku CLI installation logic and add compatibility for newer systems while preserving support for older ones. Existing functionality is maintained, and no other parts of the script or project are affected.
Compliance
GUS Ticket