Skip to content

Conversation

@brittanyrjones
Copy link
Contributor

@brittanyrjones brittanyrjones commented Jul 16, 2025

This PR adds an alias to the renamed pg:setting explain_data_connector_details to data_connector_details_logs. We need to add the alias to remediate making a breaking change to the CLI.

https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002BpMjhYAF/view
related shogun backend PR: https://github.com/heroku/shogun/pull/20599
related staging doc updates: https://salesforce-internal.slack.com/archives/CCS6NJYG2/p1743180785156639?thread_ts=1742919403.551169&cid=CCS6NJYG2

Testing
Point local CLI to my staging shogun with backend changes: https://github.com/heroku/shogun/pull/20566, and run the new command

./bin/run pg:settings:data-connector-details-logs postgresql-bjones-rigid-84072 on -a bjones-test
data-connector-details-logs has been set to true for postgresql-bjones-rigid-84072.
Data replication slot details will be logged.
./bin/run pg:settings:data-connector-details-logs postgresql-bjones-rigid-84072 off -a bjones-test
data-connector-details-logs has been set to false for postgresql-bjones-rigid-84072.
Data replication slot details will no longer be logged.

Ensure old command still works too

./bin/run pg:settings:explain-data-connector-details postgresql-bjones-rigid-84072 on -a bjones-test
data-connector-details-logs has been set to true for postgresql-bjones-rigid-84072.
Data replication slot details will be logged.
./bin/run pg:settings:explain-data-connector-details postgresql-bjones-rigid-84072 off -a bjones-test
data-connector-details-logs has been set to false for postgresql-bjones-rigid-84072.
Data replication slot details will no longer be logged.

@brittanyrjones brittanyrjones changed the title adding alias feat: adding alias Jul 16, 2025
@brittanyrjones brittanyrjones marked this pull request as ready for review July 16, 2025 18:00
@brittanyrjones brittanyrjones requested a review from a team as a code owner July 16, 2025 18:00
@k80bowman k80bowman merged commit 7b83b54 into main Jul 17, 2025
8 checks passed
@k80bowman k80bowman deleted the bj/add-alias-to-setting branch July 17, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants