-
Notifications
You must be signed in to change notification settings - Fork 234
feat(W-19005486): add support for SF Trust API to status command #3357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tlowrimore-heroku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@k80bowman I left a comment on packages/cli/src/commands/status.ts. It appears there are some logical statements that are not expressed in a way that yields the desired outcome. Of course, I'm making an assumption about what the desired outcome is.
tlowrimore-heroku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks great!
Adds support for SF Trust API to the
heroku statuscommand.Details
There is a lot of logic in here for formatting the responses from the SF Trust API endpoints. The basic outline of the logic is as follows:
Testing
yarnandyarn build./bin/run statusto see responses from the Heroku Status APITRUST_ONLY=true ./bin/run statusto see responses from the SF Trust APITRUST_ONLY=true SF_TRUST_STAGING=true ./bin/run statusto see responses from the SF Trust staging APIW-19005486