Skip to content

Conversation

@k80bowman
Copy link
Contributor

Bumps the version of @heroku-cli/command in order to apply domain name validation for Heroku API requests. Also bumps the version of @heroku/http-call.

Testing

  • Check out this branch and run yarn and yarn build
  • Run HEROKU_HOST=bogus-domain.com ./bin/run whoami
    • You should see a string of warning messages indicating that you have provided an invalid domain and that the default domain is being used instead. We are aware that there are a lot of warning messages that are currently being printed. We will be improving that as part of some follow-up work.

W-19386384

@k80bowman k80bowman requested a review from a team as a code owner August 21, 2025 19:24
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k80bowman k80bowman merged commit b139bad into main Aug 26, 2025
8 checks passed
@k80bowman k80bowman deleted the k80/bump-cli-command branch August 26, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants