Skip to content

Conversation

@michaelmalave
Copy link
Contributor

@michaelmalave michaelmalave commented Sep 4, 2025

Bumps the version of @heroku-cli/command in order to update domain name validation for Heroku API requests.

Testing

  • Check out this branch and run
  • yarn && yarn build
    Run commands
HEROKU_HOST=heroku.com ./bin/run whoami
HEROKU_HOST=herokai.com ./bin/run whoami
HEROKU_HOST=bogus-domain.com ./bin/run whoami

You should see successful command run for heroku and heroku
For bogus-domain.com, see a string of warning messages indicating that you have provided an invalid domain and that the default domain is being used instead. We are aware that there are a lot of warning messages that are currently being printed. We will be improving that as part of some follow-up work.

Gus Work Item: W-19527406

@michaelmalave michaelmalave requested a review from a team as a code owner September 4, 2025 19:55
@michaelmalave michaelmalave merged commit 3a8d7c1 into main Sep 4, 2025
8 checks passed
@michaelmalave michaelmalave deleted the mm/bump-heroku-cli-command branch September 4, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants