feat: Prepend launcher to heroku run commands for fir
#3374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback to disable Introduces a --no-launcher flag to both the run and run:detached commands, allowing users to prevent the automatic prepending of 'launcher' to commands on CNB apps. Updates command descriptions and integration tests to cover the new flag.
…ing `-- launcher` Replaces the use of buildCommand and app stack checks with buildCommandWithLauncher for constructing the dyno command. This simplifies logic and centralizes launcher handling.
eablack
approved these changes
Sep 19, 2025
Contributor
eablack
left a comment
eablack
left a comment
There was a problem hiding this comment.
can we add a test to unit/lib/run/helpers.unit.test.ts for the new buildCommandWithLauncher function? otherwise, LGTM! nice work!
Introduces unit tests for the buildCommandWithLauncher function, covering CNB and non-CNB app scenarios and the launcher disable flag.
mandelbro
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
mandelbro
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
mandelbro
deleted the
montes/feat/prepend-launcher-to-fir-run-commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make
heroku runcommands more intuitive by ensuring that common/expected binaries are in the dyno's path, we need to add "-- launcher" to the beginning of every command that users want to run. For example, if the user runs the commandheroku run bash -a MY_APP, the command should be called as "heroku run -- launcher bash -a MY_APP".Since there may be cases where user want to run the command without using "launcher", this change includes a param
--no-launcherwhich can be used to remove it from the command.This change was previously introduced to the
heroku run:insidecommand in #3116, so I refactored that command to use the shared helper that is used byheroku run.SOC 2 Compliance
GUS work item
Slack thread