chore: Refactor 'pg' commands (W-19689929) #3381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbosio
changed the title
sbosio
force-pushed
the
sbosio/update-cli-util
branch
from
74ef2a4 to
185fadc
Compare
k80bowman
approved these changes
Oct 3, 2025
Contributor
k80bowman
left a comment
k80bowman
left a comment
There was a problem hiding this comment.
The changes are pretty straightforward. Thank you for finding those places where the code doesn't match expectations and adding comments. We should definitely look into resolving those in the future. I had one small non-blocking comment, really just an observation more than anything else. I was able to test many of the commands and they all worked as expected. Thank you so much for taking this work on!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we refactor the usage of the
pgfunctions included in Core CLI, replacing them with the refactored implementation of those libraries found in@heroku/heroku-cli-util. The reason to do all of this is to get rid of a dependency on an old version ofssh-tunnelthat causes problems with Gyp builder when installing the CLI or plugins.Testing
yarn && yarn buildpgcommands over test databases as possible.SOC2 Compliance
GUS WI: W-19689929