feat: NGPG types and command utils (W-20610475) #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR copies and refactors the types and utils required for the migration of NGPG plugin commands to Core CLI v11.x.
Initially, I followed the WI instructions and put the types file under
packages/cli/types/data.ts, but that caused a hard to debug issue where all tests usingrunCommandfrom@oclif/testwould fail. Strangely, those based on ourrunCommandhelper didn't. That's why I decided to relocate the file underpackages/cli/src/lib/data/types.ts, that fixed the problem, but I still don't understand why.Some tests required to bring in some of the fixtures defined in NGPG code base. In the same spirit of splitting the utils to their own files I just copied the required fixtures on its own file under
packages/cli/test/fixtures/data.Testing
SOC2 Compliance
GUS WI: W-20610475