This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Remove erroneous comment about listener container blocking#2
Open
joekarl wants to merge 1 commit intoheroku:masterfrom
Open
Remove erroneous comment about listener container blocking#2joekarl wants to merge 1 commit intoheroku:masterfrom
joekarl wants to merge 1 commit intoheroku:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment is wrong and misleading... Specifically it does not block, the main thread completes, but due to the listenerContainer threads being backgrounded, the JVM process does not exit till the listenerContainer threads complete.
This is confusing to people who don't understand how spring rabbit works....