Closed
Conversation
2 tasks
merwok
reviewed
Mar 26, 2019
|
|
||
| # Exit early if app is clearly not Python. | ||
| if [ ! -f "$BUILD_DIR/requirements.txt" ] && [ ! -f "$BUILD_DIR/setup.py" ] && [ ! -f "$BUILD_DIR/Pipfile" ]; then | ||
| if [ -f "$BUILD_DIR/requirements.txt" ] || [ -f "$BUILD_DIR/setup.py" ] || [ -f "$BUILD_DIR/Pipfile" ] || [ -f "$BUILD_DIR/Pipfile.lock"] || [ -f "$BUILD_DIR/pyproject.py"] || [ -f "$BUILD_DIR/poetry.lock"]; then |
|
Hey @AndreGuerra123, finally got around to testing your build pack up on heroku. Turns out it doesn't really work, this is the output of a poetry init'd application: I'll go through your code, check what's going on and drop a review so you can fix it. |
Contributor
|
Hi @AndreGuerra123 ! Thanks for the pr! ❤️ 🌮 ❤️ I appreciate the time you've spent here. There have been several different poetry support prs, and after reviewing them all, #835's implementation is the one I'll be moving forward with. The good news is that this functionality should be coming soon 👍thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a pull request for Poetry suporte. All tests passed. I simply cannot squash the commits I had done during testing. Hope some git guru could find a way to do it.
Best regards,
Andre
PS: Change.log and Docs should be updated after this since I have not run it throw the CI yet.