refactor: convert type comments to type hints#255
Merged
jooola merged 9 commits intohetznercloud:mainfrom Jul 31, 2023
Merged
Conversation
apricote
changed the title
apricote
reviewed
Jul 26, 2023
Co-authored-by: Julian Tölle <julian.toelle97@gmail.com>
apricote
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The converts the type comments into type hints, and adds a few extra typing fixes.
Also improved readability by breaking down long typed argument lists on multiple lines.
Removing the types from the docstrings will be done in a future PR or gradually while improving the docstrings.